Skip to content

[win32] ImageDataProvider getBounds performance #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[win32] ImageDataProvider getBounds performance #2564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2330,8 +2330,14 @@ private ImageHandle initializeHandleFromSource(int zoom) {

@Override
protected Rectangle getBounds(int zoom) {
ImageData imageData = getImageData(zoom);
return new Rectangle(0, 0, imageData.width, imageData.height);
if (cachedImageData.containsKey(zoom)) {
ImageData imageData = cachedImageData.get(zoom);
return new Rectangle(0, 0, imageData.width, imageData.height);
}
ElementAtZoom<ImageData> imageDataAtZoom = loadImageData(zoom);
ImageData imageData = imageDataAtZoom.element();
Rectangle currentSize = new Rectangle(0, 0, imageData.width, imageData.height);
return Win32DPIUtils.scaleBounds(currentSize, zoom, imageDataAtZoom.zoom());
}
}

Expand Down
Loading