Skip to content

Conversation

@akurtakov
Copy link
Member

Translating coordinates from client area to GtkWindow for Gtk 4.x made the wrong assumption that it should reduce allocation.height with the offset (header/titlebar height) which makes no sense as it shrinks the window vertically.

Translating coordinates from client area to GtkWindow for Gtk 4.x made
the wrong assumption that it should reduce allocation.height with the
offset (header/titlebar height) which makes no sense as it shrinks the
window vertically.
@akurtakov akurtakov added the gtk4 GTK4 issues label Sep 30, 2025
@akurtakov akurtakov self-assigned this Sep 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Test Results

   88 files   - 30     88 suites   - 30   8m 10s ⏱️ - 3m 37s
4 546 tests  - 37  4 512 ✅  - 35  34 💤  - 2  0 ❌ ±0 
  261 runs   - 69    239 ✅  - 68  22 💤  - 1  0 ❌ ±0 

Results for commit 75d80f2. ± Comparison against base commit 99aff36.

This pull request removes 37 tests.
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Contributor

I see the test failure is a Clipboard related test. I'll create a PR/issue for that soon.

@akurtakov
Copy link
Member Author

Merging as it's actually reducing the failures on GTK 4.

@akurtakov akurtakov merged commit c781f19 into eclipse-platform:master Sep 30, 2025
19 of 22 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gtk4 GTK4 issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants