Control.flushQueueOnDnd: simplify commit

[tmssngr]

Inlined sendOrPost for this special case making it more obvious that an (immediate) sendEvent is happening.

[github-actions]

Test Results

  118 files  + 3    118 suites  +3   14m 53s ⏱️ + 3m 52s
4 650 tests +37  4 633 ✅ +36  17 💤 +1  0 ❌ ±0 
  330 runs  +18    326 ✅ +17   4 💤 +1  0 ❌ ±0 

Results for commit abe2183. ± Comparison against base commit 4722846.

♻️ This comment has been updated with latest results.

[akurtakov]

Setting data to null is not needed too. Please remove it, it might have the positive side effect of not losing any other data that could have been there.

[tmssngr]

It is taken from sendOrPost.

[merks]

Yes, formerly it was setting true into data so that this method would do a send and this method does also set data to null:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java

Lines 5128 to 5140 in 0e04bc9

	private boolean sendOrPost(int type, Event event) {
	assert event.data != null : "event.data should have been a Boolean, but received null";
	boolean send = (Boolean) event.data;
	event.data = null;
	if (send) {
	sendEvent (type, event);
	if (isDisposed ()) return false;
	} else {
	postEvent (type, event);
	}
	return event.doit;
	}

But I don't think there is a compelling reason to set data to null to maybe replace some other value. If there is another value in data (in the future), replacing it with null is like to be unhelpful.

[tmssngr]

You propose to change event.data while I want to keep it null as is. Maybe some application code relies on having event.data set null?