Skip to content

Re-enable Display.post tests #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Re-enable Display.post tests #2576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions ...t.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Display.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,14 +1065,6 @@ public void test_mapLorg_eclipse_swt_widgets_ControlLorg_eclipse_swt_widgets_Con

@Test
public void test_postLorg_eclipse_swt_widgets_Event() {
if (SwtTestUtil.isGTK || SwtTestUtil.isCocoa || SwtTestUtil.isWindows ) {
//TODO Fix/revisit GTK, Cocoa and Win10 failure test-case via bug 553754
if (SwtTestUtil.verbose) {
System.out.println("Excluded test_postLorg_eclipse_swt_widgets_Event(org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Display)");
}
return;
}

final int KEYCODE = SWT.SHIFT;

Display display = new Display();
Expand All @@ -1088,13 +1080,19 @@ public void test_postLorg_eclipse_swt_widgets_Event() {
shell.setBounds(display.getBounds());
shell.open();

// The display.post needs to successfully obtain the focused window (at least on GTK3)
// so we can send events to it. This processEvents gives SWT/GTK time to draw/focus/etc
// the window so that org.eclipse.swt.widgets.Display.findFocusedWindow()
// returns non-zero
SwtTestUtil.processEvents();

Event event;

// Test key events (down/up)
event = new Event();
event.type = SWT.KeyDown;
event.keyCode = -1; // bogus key code; default 0 character
assertTrue(display.post(event), "Display#post failed, probably because screen is not rendered (bug 407862)"); //$NON-NLS-1$
assertTrue(display.post(event), "Display#post failed, probably because screen is not rendered (bug 407862) or because Shell is not focussed"); //$NON-NLS-1$
// don't test KeyDown/KeyUp with a character to avoid sending to
// random window if test shell looses focus

Expand All @@ -1121,14 +1119,22 @@ public void test_postLorg_eclipse_swt_widgets_Event() {

event = new Event();
event.type = SWT.MouseDown;
assertFalse(display.post(event)); // missing button
if (!SwtTestUtil.isGTK) {
// GTK's post implementation has long allowed a button value of 0, the
// behavior of posting an event with button == 0 is undefined on GTK
assertFalse(display.post(event)); // missing button
}
event.button = 1;
shell.setFocus();
assertTrue(display.post(event));

event = new Event();
event.type = SWT.MouseUp;
assertFalse(display.post(event)); // missing button
if (!SwtTestUtil.isGTK) {
// GTK's post implementation has long allowed a button value of 0, the
// behavior of posting an event with button == 0 is undefined on GTK
assertFalse(display.post(event)); // missing button
}
event.button = 1;
shell.setFocus();
assertTrue(display.post(event));
Expand Down
Loading