[GTK4] Update to new API for running javascript #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
The API for getting the request information (from which URI is extracted) changed between GTK3 and GTK4 (technically between webkit2gtk 4 and webkitgtk 6) This needs to work so we can enable javascript and is therefore required as a pre-requisite to make eclipse-platform#2667 work. Part of eclipse-platform#2667
The API for running javascript and integrating with javascript objects and types has changed substantially between GTK3 and GTK4 (technically between webkit2gtk 4 and webkitgtk 6) The top level methods to call to run javascript changed: - webkit_web_view_run_javascript -> webkit_web_view_evaluate_javascript - webkit_web_view_run_javascript_finish -> webkit_web_view_evaluate_javascript_finish - JSValue methods -> JSCValue methods With this Browser.execute works, so for example Snippet161 now works and the ControlExample shuts down cleanly. Fixes eclipse-platform#2667
akurtakov
force-pushed
the
gtk4-javascript-evaluate
branch
from
f67a348 to
8212a73
Compare
|
Snippet161 doesn't work for me under Wayland |
For me it is almost the opposite - it works on Wayland and x11 with Xwayland, but fails on x11 with Xtigervnc. Can you try with #2713 to see if it is something simple like some code path that hits old API? |
|
I will, I just have to finish some other things. When I say it works with X11 (it means XWayland) as Fedora 43 no longer has Gnome X11 session at all (https://fedoraproject.org/wiki/Changes/WaylandOnlyGNOME) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for running javascript and integrating with javascript objects and types has changed substantially between GTK3 and GTK4 (technically between webkit2gtk 4 and webkitgtk 6)
The top level methods to call to run javascript changed:
With this Browser.execute works, so for example Snippet161 now works and the ControlExample shuts down cleanly.
Fixes #2667