Set Shell Size and the end of DPIChange #2716
Open
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the shell is scaled synchronously regardless of the sync/async behaviour of scaling. With this commit the size of the shell is set at the end of a DPIChange execution to ensure the final size set to the shell consistent with the final zoom level.
HeikoKlare
reviewed
Oct 30, 2025
There was a problem hiding this comment.
While the code looks reasonable, the change unfortunately degrades user experience. When I move a shell to another monitor and immediately stop moving the mouse without stopping to drag (i.e., without releasing the mouse button), the shell stays at a too large size (when moving from low zoom to high zoom monitor) until I move the mouse again or release the mouse button. Even when moving "ordinarily", you see that the shell is now resized multiple times (first to a larger size than what it will finally be), wheras without the change the shell just resizes once.
Here is a capture when moving from a 100% to a 125% monitor:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the shell is scaled synchronously regardless of the sync/async behaviour of scaling. With this PR the size of the shell is set at the end of a DPIChange execution to ensure the final size set to the shell consistent with the final zoom level.
Why it is necessary:
In case of a DPIChange event or multiple events, the scaling of all the widgets can happen synchronously or asynchronously. In case of asynchronous execution, the shell's size might be set before all the widgets are scaled which can lead to a weird result as resizing a shell leads to the widgets to relayout. Calling a Shell:layout at the end has similar results. It is only consistent to also set the size of the shell at the end of the execution followed by a Shell::layout.