[GTK4] Fix Control.update on Wayland #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display.flushExposes is strictly X11 specific so it makes not sense to fail Table.paintWindow() due to usage of GTK3.gtk_tree_view_get_bin_window when in the end that would not be used at all on Wayland. Gtk4/X11 case will remain broken but considering that distros stop shipping Gnome on X11 it is not worth supporting smth that users will not get easily available (https://fedoraproject.org/wiki/Changes/WaylandOnlyGNOME ). Fixes Ctrl+3 in Eclipse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display.flushExposes is strictly X11 specific so it makes not sense to fail Table.paintWindow() due to usage of
GTK3.gtk_tree_view_get_bin_window when in the end that would not be used at all on Wayland.
Gtk4/X11 case will remain broken but considering that distros stop shipping Gnome on X11 it is not worth supporting smth that users will not get easily available
(https://fedoraproject.org/wiki/Changes/WaylandOnlyGNOME ). Fixes Ctrl+3 in Eclipse.