Streamline rounding for rectangles and add rounding mode to them #2720
Conversation
HeikoKlare
force-pushed
the
rectangle-rounding-mode
branch
from
43f1a89 to
c23483c
Compare
|
@HeikoKlare I see that only RoundingMode.ROUND is used in the code for now for rectangles. Could you please explain what RoundingMode is intended to be used in which case? |
|
With the current changes, we will revert to |
|
|
||
| public void setWidth(float width) { | ||
| this.width = Math.round(width); | ||
| this.width = sizeRounding.round(width + getX()) - x; |
There was a problem hiding this comment.
I remember there were cases in the past where some places would have different results when you would scale the rectangle using scaleBounds or scaleUp because they both used different approach to scaling. One had height and width calculated using the difference between top left and bottom right and the other as just the width and height values in the object. Are we sure that this approach would not break that behavior for certain consumers? Visually I cannot see anything in the IDE but I just wanted to pick this out just to be careful. I am going to consider that since there's no test failing, this might not be the case anymore?
There was a problem hiding this comment.
I think there is no way to be 100% sure that we to not break any behavior for existing consumers. With all the back-and-forth of the kinds of rounding we have implemented, this will probably also have effects that we currently do not see (either positive or negative).
Regarding the different scaling methods that you mention: they are still in place. We still have Win32DPIUtils#scaleBounds() which implement the "other" way of scaling (used for things related to image). The modified way of scaling only applies to what is passed to Win32DPIUtils#pointToPixel()/pixelToPoint(). And there the only removed case distinction is that when a Rectangle.OfFloat was passed, no forwarding to scaleBounds() happens anymore.
There was a problem hiding this comment.
The changes look fine and introduce the rounding mode while scaling the rectangle. I do not see any visual difference in the runtime (as it should be). Hence, with the introduction of rounding mode now the rectangles scale consistently as implemented in OfFloat and WinDPIUtils. Since we have a public constructor to initialize a rectangle with a specific rounding, are there any possibilities where we will be using any other rounding mode in future? If not can we hide it for the time being?
HeikoKlare
force-pushed
the
rectangle-rounding-mode
branch
from
c23483c to
dc68e98
Compare
Sure, I've made it private for now. The class and all its methods are |
For the float-aware Point class, a rounding mode has been introduced to store in which way the Point needs to be rounded when necessary. For rectangles, this has not been implemented yet and is added by this change. It also correct the way in which rectangle values are rounded by considering the top-left and bottom-right corner instead of top-left corner and width/height, also done in the Win32DPIUtils. So it streamlines the rounding behavior in Win32DPIUtils and the Rectangle class to uniformly scale the upper left and bottom right corner of a rectangle. The changes also makes proper use of the floating-precision coordinates in the point/pixel conversions for rectangles in the Win32DPIUtils.
akoch-yatta
force-pushed
the
rectangle-rounding-mode
branch
from
dc68e98 to
03ec9bc
Compare
3 participants
For the float-aware Point class, a rounding mode has been introduced to store in which way the Point needs to be rounded when necessary. For rectangles, this has not been implemented yet and is added by this change. It also correct the way in which rectangle values are rounded by considering the top-left and bottom-right corner instead of top-left corner and width/height, also done in the Win32DPIUtils. So it streamlines the rounding behavior in Win32DPIUtils and the Rectangle class to uniformly scale the upper left and bottom right corner of a rectangle.
The changes also makes proper use of the floating-precision coordinates in the point/pixel conversions for rectangles in the Win32DPIUtils.