Skip to content

Conversation

@ptziegler
Copy link
Contributor

@ptziegler ptziegler commented Oct 6, 2023

This test should pass on Windows, but fail on Linux.
Because there, the client area matches the size of the shell, even though it should be smaller due to the decorations.

I've tested a variant where I replaced the calculation in getBoundsInPixel() with gdk_window_get_frame_extents. In principle, this works, though unreliably.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

Test Results

   539 files   -  6     539 suites   - 6   32m 35s ⏱️ + 1m 56s
 4 344 tests  - 36   4 327 ✅  - 35   15 💤  - 3  2 ❌ +2 
16 617 runs   - 33  16 476 ✅  - 33  138 💤  - 3  3 ❌ +3 

For more details on these failures, see this check.

Results for commit f87b558. ± Comparison against base commit 30797bd.

This pull request removes 37 and adds 1 tests. Note that renamed tests count towards both.
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell ‑ test_Issue828_CheckShellBounds

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

As the issue has been closed I'm closing this PR too. Please reopen with details if I misunderstood.

@akurtakov akurtakov closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants