Add wait conditions to all tests checking empty selection

Also add DisplayHelper.waitForCondition() to tests that check for empty
selection to ensure the table is fully populated before the assertion.
This prevents race conditions where the table hasn't been initialized yet.

Co-authored-by: vogella <[email protected]>

Author: Copilot

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dialogs/ResourceInitialSelectionTest.java

@@ -126,6 +126,14 @@ public void testSingleSelectionAndOneInitialNonExistingSelectionWithInitialPatte
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		// Wait for table to be populated (even if selection remains empty)
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			Table table = (Table) ((Composite) ((Composite) ((Composite) dialog.getShell().getChildren()[0])
+					.getChildren()[0]).getChildren()[0]).getChildren()[3];
+			return table.getItemCount() > 0;
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertTrue("No file should be selected by default", selected.isEmpty());
@@ -143,6 +151,14 @@ public void testSingleSelectionAndOneInitialSelectionWithoutInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		// Wait for table to be populated (even if selection remains empty)
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			Table table = (Table) ((Composite) ((Composite) ((Composite) dialog.getShell().getChildren()[0])
+					.getChildren()[0]).getChildren()[0]).getChildren()[3];
+			return table.getItemCount() > 0;
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertTrue("No file should be selected by default", selected.isEmpty());
@@ -162,6 +178,14 @@ public void testSingleSelectionAndOneFilteredSelection() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		// Wait for table to be populated (even if selection remains empty)
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			Table table = (Table) ((Composite) ((Composite) ((Composite) dialog.getShell().getChildren()[0])
+					.getChildren()[0]).getChildren()[0]).getChildren()[3];
+			return table.getItemCount() > 0;
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertTrue("No file should be selected by default", selected.isEmpty());
@@ -246,6 +270,14 @@ public void testMultiSelectionAndOneInitialSelectionWithoutInitialPattern() {
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		// Wait for table to be populated (even if selection remains empty)
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			Table table = (Table) ((Composite) ((Composite) ((Composite) dialog.getShell().getChildren()[0])
+					.getChildren()[0]).getChildren()[0]).getChildren()[3];
+			return table.getItemCount() > 0;
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertTrue("No file should be selected by default", selected.isEmpty());
@@ -265,6 +297,14 @@ public void testMultiSelectionAndTwoInitialNonExistingSelectionWithInitialPatter
 		dialog.open();
 		dialog.refresh();
 
+		Display display = PlatformUI.getWorkbench().getDisplay();
+		// Wait for table to be populated (even if selection remains empty)
+		DisplayHelper.waitForCondition(display, 3000, () -> {
+			Table table = (Table) ((Composite) ((Composite) ((Composite) dialog.getShell().getChildren()[0])
+					.getChildren()[0]).getChildren()[0]).getChildren()[3];
+			return table.getItemCount() > 0;
+		});
+
 		List<Object> selected = getSelectedItems(dialog);
 
 		assertTrue("No file should be selected by default", selected.isEmpty());