Skip to content

Commit f916646

Browse files
committed
reuse LogEntry DateTimeFormatters
1 parent 7e88f9f commit f916646

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogEntry.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ public class LogEntry extends AbstractEntry {
3131

3232
public static final String SPACE = " "; //$NON-NLS-1$
3333
public static final String F_DATE_FORMAT = "yyyy-MM-dd HH:mm:ss.SSS"; //$NON-NLS-1$
34-
private static final DateTimeFormatter GREGORIAN_SDF = DateTimeFormatter.ofPattern(F_DATE_FORMAT, Locale.ENGLISH)
34+
static final DateTimeFormatter GREGORIAN_SDF = DateTimeFormatter.ofPattern(F_DATE_FORMAT, Locale.ENGLISH)
3535
.withZone(ZoneId.systemDefault());
36-
private static final DateTimeFormatter LOCAL_SDF = DateTimeFormatter.ofPattern(F_DATE_FORMAT)
36+
static final DateTimeFormatter LOCAL_SDF = DateTimeFormatter.ofPattern(F_DATE_FORMAT)
3737
.withZone(ZoneId.systemDefault());
3838

3939
private String pluginId;

bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/LogSession.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
*******************************************************************************/
1616
package org.eclipse.ui.internal.views.log;
1717

18+
import static org.eclipse.ui.internal.views.log.LogEntry.GREGORIAN_SDF;
19+
import static org.eclipse.ui.internal.views.log.LogEntry.LOCAL_SDF;
20+
1821
import java.io.PrintWriter;
19-
import java.time.LocalDateTime;
20-
import java.time.ZoneId;
21-
import java.time.format.DateTimeFormatter;
22-
import java.time.format.DateTimeParseException;
22+
import java.time.Instant;
2323
import java.util.Date;
2424

2525
/**
@@ -33,8 +33,6 @@ public class LogSession extends Group {
3333
* @since 3.5
3434
*/
3535
public static final String SESSION = "!SESSION"; //$NON-NLS-1$
36-
private static final DateTimeFormatter LOCAL_SDF = DateTimeFormatter.ofPattern(LogEntry.F_DATE_FORMAT)
37-
.withZone(ZoneId.systemDefault());
3836

3937
private String sessionData;
4038
private Date date;
@@ -62,9 +60,12 @@ public String getFormattedDate() {
6260

6361
public void setDate(String dateString) {
6462
try {
65-
LocalDateTime ldt = LocalDateTime.parse(dateString, LOCAL_SDF);
66-
this.date = Date.from(ldt.atZone(ZoneId.systemDefault()).toInstant());
67-
} catch (DateTimeParseException e) {
63+
Date parsed = Date.from(Instant.from(GREGORIAN_SDF.parse(dateString)));
64+
if (parsed != null) {
65+
this.date = parsed;
66+
fDateString = LOCAL_SDF.format(parsed.toInstant());
67+
}
68+
} catch (Exception e) {
6869
// do nothing
6970
}
7071
}

0 commit comments

Comments
 (0)