Handle the case when application has no focus in ApplicationPartService

[laeubi]

Currently when the application has no focus there is also no active window child and in this case several actions still fail even though a part is available for perform actions.

This now handles the case of an application without focus with an empty optional to allow fall back to the part context. If that context has still no suitable part service implementation as a last resort the containing window context is used.

[github-actions]

Test Results

 1 821 files  + 1 218   1 821 suites  +1 218   1h 32m 52s ⏱️ + 1h 0m 4s
 7 734 tests +   639   7 505 ✅ +   671  228 💤  -  32  1 ❌ ±0 
24 363 runs  +16 881  23 613 ✅ +16 394  749 💤 +487  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 71070ea. ± Comparison against base commit e7ae380.

♻️ This comment has been updated with latest results.

[fedejeanne]

@laeubi thank you for contributing this. I only have a minor concern regarding the changes in the test class.

NOTE: I only skimmed through the the other changes but I haven't tested them. I could test them do it if you briefly describe how to do it.

Unrelated changes were moved to another PR

[fedejeanne]

Looks better. I'm still missing a brief "How to test" in this PR and a description of the original bug/behavior that caused this PR.

[laeubi]

Sadly the case is quite tricky to test, you need a custom RCP application, you need an external trigger (e.g. Network communication) ...

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From df35a042ad30501fa7e779daeaa48793b019ee6a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 28 Dec 2024 15:24:16 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF
index b441a8c5d3..2ea4c0a146 100644
--- a/bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench;singleton:=true
-Bundle-Version: 1.16.0.qualifier
+Bundle-Version: 1.16.100.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

[laeubi]

One additional test failure reported here:

• [mac] GlobalTemplateVariablesDateTest failed on 2024-12-29 #2649

but it suceeds now.

The other test failure is already known:

• Some ResourceInitialSelectionTest tests fail intermittently #294