Show recently used "File > New" wizards #1922

lathapatil · 2024-06-03T12:24:50Z

Changes requested in the PR
#1837 are addressed here

Fixes : #1530

iloveeclipse · 2024-06-03T12:32:45Z

@lathapatil : could you please provide some screenshot showing the change?

github-actions · 2024-06-03T13:10:06Z

Test Results

1 821 files ±0 1 821 suites ±0 1h 51m 16s ⏱️ -6s
7 712 tests ±0 7 484 ✅ +4 228 💤 ±0 0 ❌ - 3
24 297 runs ±0 23 550 ✅ +4 747 💤 ±0 0 ❌ - 3

Results for commit 3683ab5. ± Comparison against base commit 3b49502.

♻️ This comment has been updated with latest results.

lathapatil · 2024-06-03T14:33:36Z

@iloveeclipse Yes, PFB for recently used 5 new shortcuts

iloveeclipse · 2024-10-22T06:04:28Z

bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/NewWizardMenu.java

 		}
+		// To add shortcuts from OTHER... wizard regardless of perspective
+		Collection<IContributionItem> otherItems = new LinkedList<>();
+		if (!RecentNewWizardSelection.getInstance().getSelectedFromOther().isEmpty()) {


Method name getSelectedFromOther() and derived variable names are unfortunate, I had no idea how to understand these names.
Why not just RecentNewWizardSelection.getInstance().getItems() ?

iloveeclipse · 2024-10-22T06:11:59Z

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/BaseNewWizardMenu.java

+	/**
 	 * Returns the action for the given wizard id, or null if not found.
+	 *
+	 * @since 3.132


Please make the method package protected, as we don't expect anyone to overwrite it.

Please remove "since" comment after making the method package protected, as it would not be new API anymore.

If this would be changed to "public" as proposed, this would be wrong version, API tooling shows an error in the IDE. It should be 3.134 and MANIFESt.MF version should be changed from 3.133.100 to 3.134.0, because new API method would be added.

@laeubi, @HannesWell : looks like API tooling validation on jenkins stopped to work (second time I see it after #2430).
Could you please check whether is that tycho, PDE or jenkins/maven configuration issue?

iloveeclipse · 2024-10-22T06:12:57Z

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java

 	public WorkbenchPlugin() {
 		super();
 		inst = this;
+		recentNewWizardsPreferenceManager = new RecentNewWizardsPreferenceManager();


Never ever do anything in bundle constructor! Any bundle initialization code should be added in the start() method.

iloveeclipse · 2024-10-22T06:13:52Z

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java

 			if (uiBundle != null)
 				uiBundle.start(Bundle.START_TRANSIENT);
+
+			List<String> recentlyUsedNewWizards = recentNewWizardsPreferenceManager.getMenuShortcutsFromPreferences();


This code doesn't belong to the bundle activator, it is an internal implementation detail of the RecentNewWizardsPreferenceManager and should be done there.

iloveeclipse · 2024-10-22T06:14:36Z

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java

 			testableTracker = null;
 		}
+		// Store recently used new page shortcuts to preferences
+		Set<String> selectedFromOther = RecentNewWizardSelection.getInstance().getSelectedFromOther();


This code doesn't belong to the bundle activator, it is an internal implementation detail of the RecentNewWizardsPreferenceManager and should be done there. What yuo could do is to call RecentNewWizardsPreferenceManager.shutdown() here.

iloveeclipse · 2024-10-22T06:19:02Z

...es/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/NewWizardNewPage.java

 	}
+
+	/**
+	 * @return Returns the selectedElement.


Comment is meaningless. Instead, one could provide information that the selection could be null

iloveeclipse · 2024-10-22T06:19:28Z

....eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/NewWizardSelectionPage.java

 	 * they will persist into the next invocation of this wizard page
 	 */
 	protected void saveWidgetValues() {
+		RecentNewWizardSelection.getInstance().addItem(newResourcePage.getSelectedElement().getId());


newResourcePage.getSelectedElement() may return null, so please add check before.

iloveeclipse · 2024-10-22T06:19:53Z

...clipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/RecentNewWizardSelection.java

+ * of the menu manager with New Wizard actions. The recently used new wizards
+ * will appear before the "Other" shortcut.
+ *
+ * @since 3.5


please remove "since", this package is not API

iloveeclipse · 2024-10-22T06:20:50Z

...clipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/RecentNewWizardSelection.java

+public class RecentNewWizardSelection {
+	private Set<String> selectedFromOther = new LinkedHashSet<>();
+	private static RecentNewWizardSelection instance;
+	private static final int MAX_MENU_SIZE = 5;


If you intended to have 5 recent items: currently only four are kept.

If you intended to have 5 recent items: currently only four are kept.

Could you please share the scenario you tested .
It do not add the shortcuts if it is already present as part of fixed shortcuts (highlighted in the plugin perspective image) of current perspective . The last used shortcuts change if you switch the perspective .

Java perspective

When I switch to plugin perspective ..

iloveeclipse · 2024-10-22T06:21:21Z

...clipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/RecentNewWizardSelection.java

+	 * @return the set of recently used new wizard menu shortcut IDs
+	 */
+
+	public Set<String> getSelectedFromOther() {


I would propose to rename getSelectedFromOther to getItems() or getMenuIds() or getIds()

Check if API tools are working in platform UI. This PR should fail validation because it adds new API with wrong since tag. See eclipse-platform#2430 See eclipse-platform#1922

Changes requested in the PR eclipse-platform#1837 are addressed here Review points addressed

lathapatil mentioned this pull request Jun 4, 2024

Support - New Recently Used Submenu #1837

Open

lathapatil changed the title ~~Show recently used File > New wizards~~ Show recently used "File > New" wizards Jun 4, 2024

iloveeclipse force-pushed the Enhancements/1530_Recent_File_New_Submenus branch from 295f697 to 9f5a9d4 Compare July 9, 2024 15:32

iloveeclipse force-pushed the Enhancements/1530_Recent_File_New_Submenus branch from 9f5a9d4 to aecf9a8 Compare October 2, 2024 06:18

lathapatil force-pushed the Enhancements/1530_Recent_File_New_Submenus branch from aecf9a8 to 92cba6d Compare October 21, 2024 11:02

iloveeclipse requested changes Oct 22, 2024

View reviewed changes

iloveeclipse mentioned this pull request Oct 22, 2024

DO NOT MERGE #2439

Closed

Show recently used File > New wizards

3683ab5

Changes requested in the PR eclipse-platform#1837 are addressed here Review points addressed

lathapatil force-pushed the Enhancements/1530_Recent_File_New_Submenus branch from 92cba6d to 3683ab5 Compare October 25, 2024 05:00

lathapatil requested a review from iloveeclipse October 25, 2024 05:04

Show recently used "File > New" wizards #1922

Are you sure you want to change the base?

Show recently used "File > New" wizards #1922

Uh oh!

Conversation

lathapatil commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iloveeclipse commented Jun 3, 2024

Uh oh!

github-actions bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

lathapatil commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lathapatil Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lathapatil commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

lathapatil commented Jun 3, 2024 •

edited

Loading

lathapatil Oct 23, 2024 •

edited

Loading