Light (Preview) theme: Change to bg color of vertical bar in editor #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeckerWdf
reviewed
Sep 23, 2024
Member
BeckerWdf
left a comment
BeckerWdf
left a comment
There was a problem hiding this comment.
Tested on macOS. Looks good. Couldn't find any unwanted side effects.
Can somebody test on windows an linux and look for unwanted side effects?
Contributor
Member
|
@mvm-sap: Can you please. rebase and resolve the merge conflicts? |
Vertical bar next to the scroll bar in editor had white background color. This has been reverted back to grey.
mvm-sap
force-pushed
the
change_editor_right_bar_grey
branch
from
313e927 to
649381b
Compare
Contributor
Author
I have resolved merge conflicts |
Contributor
|
What is the current plan for the preview? Will it become default for the 2024-12 release? |
Member
|
pr-head fails. I see this in the log: Is this an infrastructure issue? Can we anyway merge this PR? |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical bar next to the scroll bar in editor had white background color.
This has been reverted to grey. Refer issue #2201 . Find screen shots below, captured in win os.
Before:
After:
