Skip to content

Conversation

@Wittmaxi
Copy link

@Wittmaxi Wittmaxi commented Sep 26, 2024

Introduces unit tests for the FindNextAction.
I don't achieve 100% test coverage, but I test for the most important parts. Appart from the "naive" functionality, in particular I test for:

  1. search options are taken into account
  2. the search history is honored
  3. whole - word search is only performed if the selection is a word
  4. RegExes are correctly escaped

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Test Results

 1 802 files   -  19   1 802 suites   - 19   2h 2m 3s ⏱️ + 10m 33s
 7 724 tests + 10   7 493 ✅ +  7  228 💤 ±0  2 ❌ +2  1 🔥 +1 
23 974 runs   - 329  23 230 ✅  - 326  741 💤  - 6  2 ❌ +2  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 1d02099. ± Comparison against base commit bbd9101.

♻️ This comment has been updated with latest results.

@Wittmaxi Wittmaxi marked this pull request as draft September 27, 2024 10:23
@Wittmaxi Wittmaxi force-pushed the MW_test_find_next_action branch from 2c6715a to 7021ede Compare September 27, 2024 14:33
@Wittmaxi Wittmaxi marked this pull request as ready for review September 27, 2024 14:34
@Wittmaxi Wittmaxi force-pushed the MW_test_find_next_action branch from 7021ede to 97ed40d Compare September 27, 2024 14:37
@Wittmaxi Wittmaxi force-pushed the MW_test_find_next_action branch from 97ed40d to acf9958 Compare October 16, 2024 14:07
@Wittmaxi
Copy link
Author

The test is now in the editors.test package. Reason is that I need to start a whole editor in order to test the FindNextAction using IDE.openEditor. Depending on IDE in the workbench.editors package is problematic and such @HeikoKlare and I convened on moving the test to a more sensible place.

@Wittmaxi Wittmaxi force-pushed the MW_test_find_next_action branch from acf9958 to d3947bc Compare October 16, 2024 14:09
@HeikoKlare HeikoKlare force-pushed the MW_test_find_next_action branch from d3947bc to cfda71f Compare October 29, 2024 13:39
@HeikoKlare HeikoKlare force-pushed the MW_test_find_next_action branch from cfda71f to 6bd7c0c Compare October 29, 2024 16:01
Introduces unit tests for the FindNextAction.
@HeikoKlare HeikoKlare force-pushed the MW_test_find_next_action branch from 6bd7c0c to 1d02099 Compare October 30, 2024 08:01
@Wittmaxi
Copy link
Author

@HeikoKlare thank you for updating the PR. I had copied over the method for opening an editor from another test - yet I agree that failing siletnyl is not a good idea.

@HeikoKlare
Copy link
Contributor

Thank you for adding the tests, @Wittmaxi! They are executed and succeed as expected.
Other failing tests are unrelated and documented: #751, #370

@HeikoKlare HeikoKlare merged commit 392b477 into eclipse-platform:master Oct 30, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants