-
Notifications
You must be signed in to change notification settings - Fork 228
[FindNextAction] Introduce unit tests #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FindNextAction] Introduce unit tests #2330
Conversation
Test Results 1 802 files - 19 1 802 suites - 19 2h 2m 3s ⏱️ + 10m 33s For more details on these failures and errors, see this check. Results for commit 1d02099. ± Comparison against base commit bbd9101. ♻️ This comment has been updated with latest results. |
2c6715a to
7021ede
Compare
7021ede to
97ed40d
Compare
97ed40d to
acf9958
Compare
|
The test is now in the editors.test package. Reason is that I need to start a whole editor in order to test the FindNextAction using IDE.openEditor. Depending on IDE in the workbench.editors package is problematic and such @HeikoKlare and I convened on moving the test to a more sensible place. |
acf9958 to
d3947bc
Compare
d3947bc to
cfda71f
Compare
tests/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/FindNextActionTest.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.ui.editors.tests/src/org/eclipse/ui/editors/tests/FindNextActionTest.java
Outdated
Show resolved
Hide resolved
cfda71f to
6bd7c0c
Compare
Introduces unit tests for the FindNextAction.
6bd7c0c to
1d02099
Compare
|
@HeikoKlare thank you for updating the PR. I had copied over the method for opening an editor from another test - yet I agree that failing siletnyl is not a good idea. |
Introduces unit tests for the FindNextAction.
I don't achieve 100% test coverage, but I test for the most important parts. Appart from the "naive" functionality, in particular I test for: