Skip to content

Conversation

@Christopher-Hermann
Copy link
Contributor

The calls to the lines provider should be throttled. Expect at least one call and at most 3 calls.

Fixes: #2190

@Christopher-Hermann Christopher-Hermann self-assigned this Oct 10, 2024
@Christopher-Hermann Christopher-Hermann added the test junit test related things label Oct 10, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 36m 0s ⏱️ - 3m 57s
 7 708 tests ±0   7 480 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 285 runs  ±0  23 538 ✅ ±0  747 💤 ±0  0 ❌ ±0 

Results for commit aa79cee. ± Comparison against base commit 83bf670.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor

jukzi commented Oct 10, 2024

Please add something like "StickyScrollingHandlerTest:" in front of the commit message.
Such edit can be done with github ui "squash and merge" - you will be asked to edit the message:
image

The calls to the lines provider should be throttled. Expect at least one call and at most 3 calls.

Fixes: eclipse-platform#2190
@Christopher-Hermann Christopher-Hermann changed the title Improve expectation to the throttler StickyScrollingHandlerTest: Improve expectation to the throttler Oct 10, 2024
@Christopher-Hermann
Copy link
Contributor Author

Please add something like "StickyScrollingHandlerTest:" in front of the commit message.

Done

@BeckerWdf BeckerWdf merged commit a022116 into eclipse-platform:master Oct 11, 2024
15 checks passed
@BeckerWdf BeckerWdf added this to the 4.34 M2 milestone Oct 11, 2024
@Christopher-Hermann Christopher-Hermann deleted the fixUnitTest branch October 14, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test junit test related things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StickyScrollingHandlerTest.testThrottledExecution fails on mac

3 participants