Skip to content

Conversation

@ptziegler
Copy link
Contributor

This is a continuation of #2290 and attempts to perform an XPath evaluation of the EObjects via the native javax.xml.xpath API rather than relying on JXPath. The Java model is converted to an XML structure where each EObject is mapped to a DOM node. The XPath is applied on the root node and the resulting nodes are then converted back to EObjects.

@ptziegler
Copy link
Contributor Author

@HannesWell As the tests will hopefully show, the current state should support generic XPaths such as //mainMenu/children and also properly handle the parent context (albeit untested). The only thing that doesn't work the same way is /.

@ptziegler ptziegler marked this pull request as draft October 11, 2024 04:31
@github-actions
Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 30m 3s ⏱️ - 3m 3s
 7 711 tests +3   7 482 ✅ +3  228 💤 ±0  1 ❌ ±0 
24 294 runs  +9  23 544 ✅ +7  747 💤 ±0  3 ❌ +2 

For more details on these failures, see this check.

Results for commit dc9d2d4. ± Comparison against base commit 4e0740d.

This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingAllMenus
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheApplication
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheMainMenu
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingAllMenus[0]
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingAllMenus[1]
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheApplication[0]
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheApplication[1]
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheMainMenu[0]
org.eclipse.e4.emf.xpath.test.ExampleQueriesApplicationTest ‑ testAccessingTheMainMenu[1]

@HannesWell HannesWell mentioned this pull request Jan 14, 2025
@HannesWell
Copy link
Member

With #2290 being submitted, this is not necessary anymore.
Nevertheless, thank you for your help!

@HannesWell HannesWell closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants