Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented Oct 12, 2024

  • This property is supposed to have a training space which was specified by \ but the space as removed which then continues the property value onto the next line which is not the desired effect and results in the ThemingEnabled property being missing.

- This property is supposed to have a training space which was specified
by `\ ` but the space as removed which then continues the property value
onto the next line which is not the desired effect and results in the
ThemingEnabled property being missing.
merks referenced this pull request Oct 12, 2024
Make more clear that these two setting belong together.

Change-Id: Idf0c683df571ae124e8166e4dcf6bb9536debbb3
@github-actions
Copy link
Contributor

Test Results

 1 815 files   -   3   1 815 suites   - 3   1h 25m 33s ⏱️ - 17m 9s
 7 664 tests  -  45   7 327 ✅  - 154  228 💤 ± 0  0 ❌ ±0  109 🔥 +109 
24 160 runs   - 128  23 101 ✅  - 440  725 💤  - 22  0 ❌ ±0  334 🔥 +334 

For more details on these errors, see this check.

Results for commit e13b35f. ± Comparison against base commit dea7b79.

This pull request removes 45 tests.
org.eclipse.ui.genericeditor.tests.AutoEditTest ‑ testAutoEdit
org.eclipse.ui.genericeditor.tests.AutoEditTest ‑ testEnabledWhenAutoEdit
org.eclipse.ui.genericeditor.tests.BasicEditionTest ‑ testNewLineHasIndent
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletion
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionFreeze_bug521484
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionService
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionUsingViewerSelection
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testDefaultContentAssistBug570488
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testEnabledWhenCompletion
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testMoveCaretBackUsesAllProcessors_bug522255
…

@merks
Copy link
Contributor Author

merks commented Oct 12, 2024

There seems to be an avalanche of failures, but I'm doubtful any of it is related to this trivial change. Does anyone know what's going on?

@laeubi
Copy link
Contributor

laeubi commented Oct 12, 2024

@merks
Copy link
Contributor Author

merks commented Oct 12, 2024

I'm going to assume that while there major problems, they are not related to adding a space back from where it was recently remove.

@merks merks merged commit 1eead54 into eclipse-platform:master Oct 12, 2024
8 of 15 checks passed
@merks merks deleted the pr-missing-ThemingEnabled_ branch October 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants