-
Notifications
You must be signed in to change notification settings - Fork 228
Add component property types for IModelProcessorContribution attributes #2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component property types for IModelProcessorContribution attributes #2396
Conversation
...se.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/modeling/IModelProcessorContribution.java
Outdated
Show resolved
Hide resolved
...se.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/modeling/IModelProcessorContribution.java
Outdated
Show resolved
Hide resolved
Test Results 1 818 files 1 818 suites 1h 31m 19s ⏱️ Results for commit 02f399f. ♻️ This comment has been updated with latest results. |
60e584d to
1cab632
Compare
|
If there are no more remarks I plan to submit this tomorrow (European) evening. Ideally we would also have some places within the SDK were this would be used, but I could not find any place were this is immediately possible. If I understood it correctly, in order to use it, we would have to migrate some (or all) of the |
|
@HannesWell The option to use DS for contributing a model processor was intended to be an option for people that don't like the extension points in their code. There was no need to migrate the platform model processors. Also note that for the existing ones there is no need for the component property types, as the And btw the |
These annotation simplify the specification of the 'beforefragment' and 'apply' service property for IModelProcessorContribution implementations and makes it type-safe and more robust: ''' @component(service = IModelProcessorContribution.class) @IModelProcessorContribution.Beforefragment(true) @IModelProcessorContribution.Apply(IModelProcessorContribution.APPLY_ALWAYS) public class SampleContribution implements IModelProcessorContribution { '''
1cab632 to
02f399f
Compare
|
Thanks for that. But this change is ready now. |
Broken by eclipse-platform#2396
Broken by eclipse-platform#2396
These annotation simplify the specification of the 'beforefragment' and 'apply' service property for
IModelProcessorContribution implementations and makes it type-safe and more robust: