Skip to content

Conversation

@HannesWell
Copy link
Member

@fipro78 do you want to review this?

@HannesWell HannesWell requested a review from fipro78 October 19, 2024 11:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 44m 34s ⏱️ - 9m 52s
 7 725 tests ±0   7 496 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 336 runs  ±0  23 588 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 62e7e5b. ± Comparison against base commit 560db2a.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the cleanup-modelassembler branch from 16644c2 to b15598d Compare October 19, 2024 14:12
Copy link
Contributor

@fipro78 fipro78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@vogella vogella self-requested a review November 6, 2024 16:15
Copy link
Contributor

@vogella vogella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@HannesWell HannesWell force-pushed the cleanup-modelassembler branch from b15598d to 62e7e5b Compare November 6, 2024 23:36
@HannesWell
Copy link
Member Author

Thank you.

The test failure seems unrelated, submitting.

@HannesWell HannesWell merged commit 908db0f into eclipse-platform:master Nov 7, 2024
15 of 17 checks passed
@HannesWell HannesWell deleted the cleanup-modelassembler branch November 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants