CloseAllHandlerTest cleanup #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use static imports and pattern matching to ease reading.
Contributor
Test Results 1 821 files 1 821 suites 1h 44m 47s ⏱️ Results for commit 0a7597e. |
HannesWell
reviewed
Oct 26, 2024
Comment on lines
+144
to
145
| assertTrue("Active workbench window not found.", activeWindow instanceof IWorkbenchWindow); | ||
| IWorkbenchWindow window = (IWorkbenchWindow) activeWindow; |
Member
There was a problem hiding this comment.
Probably the following would be possible, but not everyone finds it more readable.
Suggested change
| assertTrue("Active workbench window not found.", activeWindow instanceof IWorkbenchWindow); | |
| IWorkbenchWindow window = (IWorkbenchWindow) activeWindow; | |
| assertTrue("Active workbench window not found.", activeWindow instanceof IWorkbenchWindow window); |
Member
Author
There was a problem hiding this comment.
Unfortunately this is not possible as that way window variable is local to the assertTrue call and thus not resolved outside of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use static imports and pattern matching to ease reading.