Skip to content

Stop using assertTrue(false) #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Stop using assertTrue(false) #2468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
682821c
Stop using assertTrue(false)
akurtakov Oct 30, 2024
2ceb19c
Version bump(s) for 4.34 stream
eclipse-platform-bot Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/HTML2TextReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2006, 2016 IBM Corporation and others.
* Copyright (c) 2006, 2024 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -16,6 +16,7 @@

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.io.IOException;
import java.io.Reader;
Expand Down Expand Up @@ -76,7 +77,7 @@ private void verify(String input, String expectedOutput, int styleRangeCount) th
StyleRange range2= ranges.get(i + 1);

if (range1.start + range1.length > range2.start) {
assertTrue("StyleRanges overlap", false);
fail("StyleRanges overlap");
}
}

Expand Down Expand Up @@ -108,7 +109,7 @@ private void verify(String input, String expectedOutput, StyleRange[] styleRange
StyleRange range2= ranges.get(i + 1);

if (range1.start + range1.length > range2.start) {
assertTrue("StyleRanges overlap", false);
fail("StyleRanges overlap");
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/org.eclipse.text.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.text.tests
Bundle-Version: 3.14.600.qualifier
Bundle-Version: 3.14.700.qualifier
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Export-Package:
Expand Down
8 changes: 4 additions & 4 deletions tests/org.eclipse.text.tests/src/org/eclipse/text/tests/AnnotationModelExtension2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2007, 2015 IBM Corporation and others.
* Copyright (c) 2007, 2024 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -13,7 +13,7 @@
*******************************************************************************/
package org.eclipse.text.tests;

import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.util.ArrayList;
import java.util.Arrays;
Expand Down Expand Up @@ -139,7 +139,7 @@ private void assertEquals(Annotation[] expected, Annotation[] actual, IAnnotatio
for (Annotation a : actual) {
if (!expectedSet.contains(a)) {
String message = "Unexpected annotation " + getName(a) + " in result with models [" + getAnnotationModelNames(insideModel, beforeModel, afterModel) + "]";
assertTrue(message, false);
fail(message);
}
expectedSet.remove(a);
}
Expand All @@ -149,7 +149,7 @@ private void assertEquals(Annotation[] expected, Annotation[] actual, IAnnotatio
for (Annotation missing : expectedSet) {
message= message + "\n" + getName(missing);
}
assertTrue(message, false);
fail(message);
}
}

Expand Down
Loading
Loading