Fixes to issue #2313 Light (Preview) Theme #2485
Conversation
mai-tran-03
changed the title
|
getCustomThemeFlag was introduced with e60b130 which was a fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=506553 |
opcoach
left a comment
opcoach
left a comment
There was a problem hiding this comment.
I rebased your contribution on master locally, launched it, and ran a 'clean all the projects' installed (I imported all the platform ui projects in my workspace). it is working well with or without a theme and whatever the theme chosen for the 'building' progress...
Please give a good name to the method used even if the method is private.
| ITheme activeTheme = engine.getActiveTheme(); | ||
| if (activeTheme != null) { | ||
| return !DEFAULT_THEME.equals(activeTheme.getId()); | ||
| return DARK_THEME.equals(activeTheme.getId()); |
There was a problem hiding this comment.
the getCustomThemeFlag() says in the javadoc that it is returning true if a theme is selected. But the method returns true if the current theme is the dark one. even if this is a private method, it could be renamed into 'isDarkThemeSelected'
|
@BeckerWdf is this PR included in or superseded by #2549? |
no it's not. |
|
This PR does not touch the theme's css file at all. So it's not really related. |
mai-tran-03
force-pushed
the
mai_tran
branch
2 times, most recently
from
3b7d187 to
226fc15
Compare
mai-tran-03
force-pushed
the
mai_tran
branch
from
226fc15 to
5c65cbc
Compare
|
@opcoach Thank you for reviewing this pull request. I made the change you requested to rename the function. I accidentally closed this PR and I do not have permission to reopen it. Can you reopen it for me? I believe it is ready to be merged. |
|
This PR is empty and has no more commit inside. I think you should create a new one. I can't reopen it as it is empty. |
4 participants
Since the progress item background color is inconsistent in the light preview theme and is fine in other themes, I explicitly made
DARK_THEMEa custom theme so it would still have its color components while the background color is consistent in the light preview.Fixes #2313