Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 6, 2024

These methods are not used since the 3.x migration, time to mark them for deletion.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 51m 59s ⏱️ - 3m 30s
 7 725 tests ±0   7 496 ✅ ±0  228 💤 ±0  1 ❌ ±0 
24 336 runs  ±0  23 588 ✅ ±0  747 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 560c490. ± Comparison against base commit beb9918.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor Author

vogella commented Nov 6, 2024

Awesome this new quality gate check! This prevented me from adding more warnings to the build. I assume I have to thank you @laeubi for this. Great work!

These methods are not used since the 3.x migration, time to mark them
for deletion.
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.tests.rcp/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From e98b11fa5800f672a8f8c8ea565ef385663b1cf6 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 7 Jan 2025 12:18:01 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/tests/org.eclipse.ui.tests.rcp/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests.rcp/META-INF/MANIFEST.MF
index 85c4154a3d..d0343bfdb2 100644
--- a/tests/org.eclipse.ui.tests.rcp/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.tests.rcp/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.tests.rcp; singleton:=true
-Bundle-Version: 3.6.500.qualifier
+Bundle-Version: 3.6.600.qualifier
 Bundle-Vendor: %providerName
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.ui,
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

* window contents in their application model.
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2024-12")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release is wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Remote is different for for me, will close PR and recreate

@vogella vogella closed this Jan 7, 2025
@vogella vogella deleted the workbench-window-advisor-mark-methods-for-deletion branch January 7, 2025 12:45
@vogella
Copy link
Contributor Author

vogella commented Jan 7, 2025

#2670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants