org.eclipse.search.core requires org.eclipse.core.resources 3.21.100 #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HannesWell
requested changes
Nov 10, 2024
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thank you for this PR. I just have a small request for change.
org.eclipse.search.internal.core.text.FileCharSequenceProvider.toShortString(...) requires the method 'byte[] org.eclipse.core.resources.IFile.readNBytes(int)' which was introduced in org.eclipse.core.resources 3.21.100. See also commit 906371d
HannesWell
approved these changes
Nov 10, 2024
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thanks Holger for this fix.
In general please amend the existing commit of a PR and force-push it to your PR branch.
There is no need to capture the review process in the git-history and Github's squash-and-merge does not lead to satisfying results. I have done that for you know so that this can be submitted now.
Member
|
Test failure on Jenkins is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.eclipse.search.internal.core.text.FileCharSequenceProvider.toShortString(...)requires the methodbyte[] org.eclipse.core.resources.IFile.readNBytes(int)which was introduced in org.eclipse.core.resources 3.21.100.The increasing of the lower bound of that requirement was missed in eclipse-platform/eclipse.platform@906371d.
Fixes eclipse-m2e/m2e-core#1886