Skip to content

Expanding trees below now possible on linux #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Expanding trees below now possible on linux #2533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ff9c36
with the changes to TypeHierarchyViewPart, it is now possible to expand
jannisCode Nov 25, 2024
59c55a8
Version bump(s) for 4.35 stream
eclipse-platform-bot Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface;singleton:=true
Bundle-Version: 3.35.100.qualifier
Bundle-Version: 3.35.200.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.jface,
Expand Down
7 changes: 3 additions & 4 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,9 +1857,6 @@ private void internalConditionalExpandToLevel(Widget widget, int level,
}
createChildren(widget, false);
// XXX for performance widget should be expanded after expanding children:
if (widget instanceof Item it) {
setExpanded(it, true);
}
if (level == ALL_LEVELS || level > 1) {
Item[] children = getChildren(widget);
if (children != null) {
Expand All @@ -1872,7 +1869,9 @@ private void internalConditionalExpandToLevel(Widget widget, int level,
}
}
}
// XXX expanding here fails on linux
if (widget instanceof Item it) {
setExpanded(it, true);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion features/org.eclipse.e4.rcp/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="org.eclipse.e4.rcp"
label="%featureName"
version="4.34.0.qualifier"
version="4.34.100.qualifier"
provider-name="%providerName"
license-feature="org.eclipse.license"
license-feature-version="0.0.0">
Expand Down
Loading