Skip to content

Bugfix for Hover which is visible above other application windows. #2534 #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Bugfix for Hover which is visible above other application windows. #2534 #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface.text
Bundle-Version: 3.26.0.qualifier
Bundle-Version: 3.26.100.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package:
Expand Down
4 changes: 2 additions & 2 deletions ...clipse.jface.text/src/org/eclipse/jface/internal/text/html/BrowserInformationControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,6 @@ else if (!resizable)
@Override
public void setVisible(boolean visible) {
Shell shell= getShell();
if (shell.isVisible() == visible)
return;

if (!visible) {
super.setVisible(false);
Expand All @@ -342,6 +340,8 @@ public void setVisible(boolean visible) {
return;
}

if (shell.isVisible() == visible)
return;
/*
* The Browser widget flickers when made visible while it is not completely loaded.
* The fix is to delay the call to setVisible until either loading is completed
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/AbstractInformationControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ public boolean isResizable() {

@Override
public void setVisible(boolean visible) {
if (fShell.isVisible() == visible)
if (visible && fShell.isVisible() == visible)
return;

fShell.setVisible(visible);
Expand Down
Loading