Use SubMonintor in CheckConditionsContext #2574
Open
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 3 018 files + 341 3 018 suites +341 2h 19m 38s ⏱️ + 23m 36s For more details on these failures, see this check. Results for commit 96cd020. ± Comparison against base commit 343fd57. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
submonitor-checkconditionscontext
branch
from
90827ad to
0ebc1eb
Compare
jukzi
approved these changes
Dec 4, 2024
vogella
force-pushed
the
submonitor-checkconditionscontext
branch
from
0ebc1eb to
36b8bf4
Compare
vogella
force-pushed
the
submonitor-checkconditionscontext
branch
from
36b8bf4 to
ccccbca
Compare
done() call not necessary here and convert can also handle null. Also split will also check for cancellation so the additional cancellation check is not necessary. See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
vogella
force-pushed
the
submonitor-checkconditionscontext
branch
from
ccccbca to
96cd020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done() call not necessary here and convert can also handle null. Also split will also check for cancellation so the additional cancellation check is not necessary.
See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html