[StickyScrolling] Sticky line is considering hidden source viewer lines #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I tested this on macOS. Before the fix sticky line numbers where correct but the content was wrong. With this change everything looks good. |
BeckerWdf
approved these changes
Dec 6, 2024
Contributor
Test Results 1 821 files 1 821 suites 1h 48m 51s ⏱️ For more details on these failures, see this check. Results for commit 9dfcbaf. ♻️ This comment has been updated with latest results. |
The source viewer can contain hidden lines, for example via code folding. The sticky line needs to consider this lines (see ITextViewerExtension5) when calculating the text and the style ranges from the text widget
Christopher-Hermann
force-pushed
the
fixStickyLine
branch
from
cb2b5fa to
9dfcbaf
Compare
Contributor
Author
|
Failing tests are unrelated... |
Christopher-Hermann
merged commit f082218
into
eclipse-platform:master
9 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source viewer can contain hidden lines, for example via code folding. The sticky line needs to consider this lines (see ITextViewerExtension5) when calculating the text and the style ranges from the text widget
How to retest
Open a java class and collapse a method implementation. Sticky lines created for lines below the collapsed method was showing a wrong text.
With this fix, the correct text is displayed again.