[Dark Theme]Fix for inconsistent Git Staging view bg colors #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 1 821 files + 607 1 821 suites +607 1h 32m 49s ⏱️ + 28m 52s For more details on these failures, see this check. Results for commit 8f54610. ± Comparison against base commit bbebe70. ♻️ This comment has been updated with latest results. |
BeckerWdf
approved these changes
Dec 11, 2024
After improving the existing dark theme, Git staging view had side effects wrt the back ground colors of whole view and also the Unstaged Changes and Staged Changes section. This has been fixed with this change by applying those dark background changes only to editor.
BeckerWdf
force-pushed
the
Dark_theme_git_staging_view_fix
branch
from
b3497af to
8f54610
Compare
Member
|
failed tests are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After improving the existing dark theme #2548, the Git staging view had side effects regarding the background colors of the whole view and also the Unstaged Changes and Staged Changes section. This has been fixed with this change by applying those dark background changes only to the editor. This also fixes the bg color of tool items.
Before:
After:
