-
Notifications
You must be signed in to change notification settings - Fork 228
Stop requiring jdt.ui in o.e.ui.tests #2609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
|
Local runs improve from 21s to 8s for OpenCloseTest. |
Test Results 1 210 files - 609 1 210 suites - 609 1h 9m 56s ⏱️ - 28m 2s Results for commit d9bd38f. ± Comparison against base commit b379121. This pull request skips 5 tests.♻️ This comment has been updated with latest results. |
Good job! |
89fea37 to
cd625bb
Compare
There are enough resources available to handle tests without loading JDT UI and putting extra requirements and circular dependencies between repositories.
|
Tests worked without OOM but apitools failed. Merging. |
|
running UiTestSuite locally i still see jdt and jdt.ui in stacktraces - did i do something wrong?: |
There are enough resources available to handle tests without loading JDT UI and putting extra requirements and circular dependencies between repositories.