Skip to content

Conversation

@akurtakov
Copy link
Member

There are enough resources available to handle tests without loading JDT UI and putting extra requirements and circular dependencies between repositories.

@vogella
Copy link
Contributor

vogella commented Dec 10, 2024

LGTM

@akurtakov
Copy link
Member Author

akurtakov commented Dec 10, 2024

Local runs improve from 21s to 8s for OpenCloseTest.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

 1 210 files   -   609   1 210 suites   - 609   1h 9m 56s ⏱️ - 28m 2s
 7 729 tests ±    0   7 496 ✅  -     4  233 💤 +  5  0 ❌  - 1 
16 219 runs   - 8 111  15 704 ✅  - 7 876  515 💤  - 234  0 ❌  - 1 

Results for commit d9bd38f. ± Comparison against base commit b379121.

This pull request skips 5 tests.
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

♻️ This comment has been updated with latest results.

@jukzi jukzi added performance test junit test related things labels Dec 10, 2024
@jukzi
Copy link
Contributor

jukzi commented Dec 10, 2024

Local runs improve from 21s to 8s for OpenCloseTest.

Good job!

@akurtakov akurtakov force-pushed the master branch 2 times, most recently from 89fea37 to cd625bb Compare December 10, 2024 11:48
There are enough resources available to handle tests without loading JDT
UI and putting extra requirements and circular dependencies between
repositories.
@akurtakov
Copy link
Member Author

Tests worked without OOM but apitools failed. Merging.

@akurtakov akurtakov merged commit 78615b8 into eclipse-platform:master Dec 10, 2024
10 of 14 checks passed
@jukzi
Copy link
Contributor

jukzi commented Dec 10, 2024

running UiTestSuite locally i still see jdt and jdt.ui in stacktraces - did i do something wrong?:

testConfigurationCloseImportedProjects: setUp...

!ENTRY org.eclipse.jdt.core 4 0 2024-12-10 18:07:02.940
!MESSAGE ImportExistingProjectsWizardTestRebuildProject does not exist
!STACK 1
Java Model Exception: Error in Java Model (code 969): ImportExistingProjectsWizardTestRebuildProject does not exist
	at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException(JavaElement.java:546)
	at org.eclipse.jdt.internal.core.JavaModelManager.getPerProjectInfoCheckExistence(JavaModelManager.java:2535)
	at org.eclipse.jdt.internal.core.JavaProject.getPerProjectInfo(JavaProject.java:2329)
	at org.eclipse.jdt.internal.core.JavaProject.getOutputLocation(JavaProject.java:2144)
	at org.eclipse.jdt.internal.ui.wizards.importer.JDTProjectNatureImportConfigurator.getFoldersToIgnore(JDTProjectNatureImportConfigurator.java:89)
	at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.importProjectAndChildrenRecursively(SmartImportJob.java:462)
	at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob$1.run(SmartImportJob.java:223)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
!SUBENTRY 1 org.eclipse.jdt.core 4 969 2024-12-10 18:07:02.941
!MESSAGE ImportExistingProjectsWizardTestRebuildProject does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance test junit test related things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants