Skip to content

Conversation

@jukzi
Copy link
Contributor

@jukzi jukzi commented Dec 10, 2024

To avoid needless duplicate strings in heap (only few styles are actually used).
image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

 1 214 files   1 214 suites   1h 13m 52s ⏱️
 7 729 tests  7 496 ✅ 233 💤 0 ❌
16 232 runs  15 717 ✅ 515 💤 0 ❌

Results for commit 16c276b.

♻️ This comment has been updated with latest results.

Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help reducing the memory pressure.

@akurtakov akurtakov force-pushed the org.eclipse.e4.ui.css.swt.dom.WidgetElement.swtStyles branch from 8a003b6 to 16c276b Compare December 10, 2024 11:47
@jukzi
Copy link
Contributor Author

jukzi commented Dec 10, 2024

ignoring unrelated flaky NotifyingTreeViewer illegally extends TreeViewer

@jukzi jukzi merged commit d3971fe into eclipse-platform:master Dec 10, 2024
13 of 17 checks passed
@vogella
Copy link
Contributor

vogella commented Dec 10, 2024

Always great to see Eclipse faster and leaner. Thanks @jukzi

@jukzi jukzi deleted the org.eclipse.e4.ui.css.swt.dom.WidgetElement.swtStyles branch December 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants