Skip to content

fix UI on MacOS in refactoring wizard #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix UI on MacOS in refactoring wizard #2629

merged 1 commit into from
Dec 16, 2024

Conversation

@tobiasmelcher
Copy link
Contributor

@tobiasmelcher tobiasmelcher commented Dec 14, 2024 •
edited
Loading

Fixes: #1173

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024

Test Results

  607 files   -   607    607 suites   - 607   28m 1s ⏱️ - 23m 38s
7 729 tests ±    0  7 495 ✅  -     6  234 💤 +  6  0 ❌ ±0 
8 116 runs   - 8 116  7 882 ✅  - 7 882  234 💤  - 234  0 ❌ ±0 

Results for commit 464c001. ± Comparison against base commit 5334e3c.

This pull request skips 6 tests. 
org.eclipse.jface.text.tests.contentassist.AsyncContentAssistTest ‑ testCompleteActivationChar
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

@BeckerWdf BeckerWdf added this to the 4.35 M1 milestone Dec 16, 2024
@BeckerWdf BeckerWdf merged commit ab9e5b7 into eclipse-platform:master Dec 16, 2024
15 of 17 checks passed
@BeckerWdf
Copy link
Member

BeckerWdf commented Dec 16, 2024

thanks for fixing

jonahgraham added a commit to jonahgraham/cdt that referenced this pull request May 28, 2025
@jonahgraham
Adapt compare control to CompareConfiguration
a553fee 
This is to accomodate a bug fix done in Eclipse Platform in
eclipse-platform/eclipse.platform.ui#2629

Fixes eclipse-cdt#1172
This was referenced May 28, 2025
Merged
Merged
HeikoKlare pushed a commit that referenced this pull request May 28, 2025
@jonahgraham @HeikoKlare
Fix NPE when viewer control doesn't adapt to CompareConfiguration
22ec1e2 
Follow up to
#2629

which introduced an NPE when doing refactor->rename in CDT:
eclipse-cdt/cdt#1172
jonahgraham added a commit to eclipse-cdt/cdt that referenced this pull request May 28, 2025
@jonahgraham
Adapt compare control to CompareConfiguration (#1173)
abe4d1b 
This is to accomodate a bug fix done in Eclipse Platform in
eclipse-platform/eclipse.platform.ui#2629

Fixes #1172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merks merks merks left review comments

@jonahgraham jonahgraham jonahgraham left review comments

Assignees

@tobiasmelcher tobiasmelcher

Labels

None yet

Projects

None yet

Milestone

4.35 M1

Development

Successfully merging this pull request may close these issues.

Bad UI on MacOS for merge viewer

5 participants

@tobiasmelcher @BeckerWdf @merks @jonahgraham @tobias-melcher