Skip to content

Conversation

@mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Dec 24, 2024

PR #2455 leads to regression in the behavior of highlight of selected tabs in inactive stack. This caused only in windows and Linux and has been fixed with this change.

@mvm-sap mvm-sap changed the title [Light Theme]Fix for regression caused by Redefine color change [Light Theme]Fix for regression caused by defining colors for re-use Dec 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2024

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 34m 35s ⏱️ + 6m 48s
 7 734 tests ±0   7 505 ✅ ±0  228 💤 ±0  1 ❌ ±0 
24 363 runs  ±0  23 613 ✅ ±0  749 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6ab6375. ± Comparison against base commit 3c276e8.

♻️ This comment has been updated with latest results.

PR 2455 leads to regression in the behavior of highlight of selected
tabs in inactive stack. This caused only in windows and Linux and has
been fixed with this change
@BeckerWdf BeckerWdf force-pushed the Light_theme_regression_fix branch from c36766f to 6ab6375 Compare January 2, 2025 11:39
@BeckerWdf
Copy link
Member

Failed test is unrelated.

@BeckerWdf BeckerWdf merged commit 7f20954 into eclipse-platform:master Jan 2, 2025
15 of 17 checks passed
@BeckerWdf BeckerWdf added this to the 4.35 M1 milestone Jan 2, 2025
@mvm-sap mvm-sap deleted the Light_theme_regression_fix branch January 17, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants