Skip to content

Conversation

@BeckerWdf
Copy link
Member

@BeckerWdf BeckerWdf commented Dec 30, 2024

On macOS we use arrow symbols (see
https://www.fileformat.info/info/unicode/char/2193/index.htm) when formatting key bindings (e.g. in tooltips or menu entries). This is much more compact then writing "UP", "DOWN", etc. and looks a lot nicer.

Let's also use this on Windows and Linux.

@BeckerWdf
Copy link
Member Author

On Windows key bindings that contain the cursor keys currently look like this:
Bild

On macOS they look like this:
image

So the use arrow symbols like "↑".

Native Apps on Windows use this:
image

So writing text instead of "↑" seems to be correct but if you see closely Eclipse writes "Left" and Visual Studio write "Arrow Left" which his even longer.

VSCode on Windows does this:
image
Yet another way "ArrowLeft".

Native GTK Apps do this:
image
Even thou I did not find a key binding with including curser keys I assume that they would also use "↑" instead of something like "Up" or "Arrow Up".

I would vote for changing this to always use the symbols like "↑" on all platforms. It looks nice and does not that that much screen space.

What do you think?

@merks
Copy link
Contributor

merks commented Dec 30, 2024

As long as they render nicely, that make good sense. That's also what they look like on my keyboard. 😜

@BeckerWdf
Copy link
Member Author

That's also what they look like on my keyboard. 😜

Haha. That's true.

@BeckerWdf
Copy link
Member Author

With this change windows looks like this:
Bild (1)

@BeckerWdf BeckerWdf added this to the 4.35 M1 milestone Dec 30, 2024
@BeckerWdf
Copy link
Member Author

can somebody on Linux test this PR and provide a screenshot?

Copy link
Contributor

@tobiasmelcher tobiasmelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, thanks Matthias

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 34m 26s ⏱️ + 4m 5s
 7 734 tests ±0   7 505 ✅ ±0  228 💤 ±0  1 ❌ +1 
24 363 runs  ±0  23 613 ✅ ±0  749 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 04d4fc7. ± Comparison against base commit 7f20954.

♻️ This comment has been updated with latest results.

@tobiasmelcher
Copy link
Contributor

screenshot from Ubuntu 22.04.5 LTS
ubuntu_keys

@BeckerWdf
Copy link
Member Author

BeckerWdf commented Jan 2, 2025

screenshot from Ubuntu 22.04.5 LTS

Thanks for testing. This looks nice.

@BeckerWdf
Copy link
Member Author

If nobody objects I plan to merge this today EoB so that we can get feedback from users early.

On macOS we use arrow symbols (see
xhttps://www.fileformat.info/info/unicode/char/2193/index.htm) when
formatting key bindings (e.g. in tooltips or menu entries).
This is much more compact then writing "UP", "DOWN", etc. and looks a
lot nicer.

Let's also use this on Windows and Linux.
@BeckerWdf
Copy link
Member Author

failed test is unrelated

@BeckerWdf BeckerWdf merged commit e24ba9d into eclipse-platform:master Jan 2, 2025
15 of 17 checks passed
@BeckerWdf BeckerWdf deleted the up_and_down branch January 2, 2025 14:05
@BeckerWdf BeckerWdf self-assigned this Jan 2, 2025
@BeckerWdf BeckerWdf added noteworthy Noteworthy feature usability labels Jan 2, 2025
BeckerWdf added a commit to BeckerWdf/www.eclipse.org-eclipse that referenced this pull request Feb 17, 2025
BeckerWdf added a commit to BeckerWdf/www.eclipse.org-eclipse that referenced this pull request Feb 17, 2025
BeckerWdf added a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noteworthy Noteworthy feature usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants