Skip to content

Conversation

@Christopher-Hermann
Copy link
Contributor

The LineNumberRulerColumn should consider the text widget's LineSpacing when word wrapping is enabled.

Before the fix:
image

After the fix:
image

Fixes #2668

The LineNumberRulerColumn should consider the text widget's LineSpacing when word wrapping is enabled.

Fixes eclipse-platform#2668
@Christopher-Hermann
Copy link
Contributor Author

I tried to add unit tests, but it's too expensive to write tests since the drawing is directly done on the GC which makes it hard to assert.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 34m 25s ⏱️ - 1m 4s
 7 738 tests ±0   7 510 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 375 runs  ±0  23 626 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 34fb426. ± Comparison against base commit b3aa5b0.

@mickaelistria mickaelistria merged commit 36c6b93 into eclipse-platform:master Jan 7, 2025
17 checks passed
@mickaelistria
Copy link
Contributor

Thank you!

@Christopher-Hermann Christopher-Hermann deleted the LineNumberSpacing branch January 7, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LineNumberRulerColumn does not consider LineSpacing

2 participants