Skip to content

Do not suspend JobManager during startup by default #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Do not suspend JobManager during startup by default #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16064c
Version bump(s) for 4.35 stream
eclipse-platform-bot Jan 7, 2025
824b356
Do not suspend JobManager during startup by default
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.ide.application;singleton:=true
Bundle-Version: 1.5.600.qualifier
Bundle-Version: 1.5.700.qualifier
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
Expand Down
11 changes: 10 additions & 1 deletion ...clipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@ public class IDEApplication implements IApplication, IExecutableExtension {
*/
public static final String PLUGIN_ID = "org.eclipse.ui.ide.application"; //$NON-NLS-1$

/**
* Suspending JobManager can be forced by specify VM property:
* {@code -Dorg.eclipse.ui.suspendJobManagerDuringStart=true}
*/
static final boolean SUSPEND_JOBMANAGER_DURING_START = Boolean
.getBoolean("org.eclipse.ui.suspendJobManagerDuringStart"); //$NON-NLS-1$

/**
* Creates a new IDE application.
*/
Expand All @@ -146,7 +153,9 @@ public Object start(IApplicationContext appContext) throws Exception {
// is done to reduce resource contention during startup.
// The job manager will be resumed by the
// IDEWorkbenchAdvisor.postStartup method.
Job.getJobManager().suspend();
if (SUSPEND_JOBMANAGER_DURING_START) {
Job.getJobManager().suspend();
}

Display display = createDisplay();
// processor must be created before we start event loop
Expand Down
4 changes: 3 additions & 1 deletion ...e.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,9 @@ public void postStartup() {
} finally {
// Resume the job manager to allow background jobs to run.
// The job manager was suspended by the IDEApplication.start method.
Job.getJobManager().resume();
if (IDEApplication.SUSPEND_JOBMANAGER_DURING_START) {
Job.getJobManager().resume();
}
}
}

Expand Down
Loading