Skip to content

Conversation

@ptziegler
Copy link
Contributor

The new StringMatcher API used with
db41fb4 is only available starting with version 3.33.0 of org.eclipse.core.runtime.

See eclipse-platform/eclipse.platform#1673

The new StringMatcher API used with
db41fb4 is only available starting with
version 3.33.0 of org.eclipse.core.runtime.

See eclipse-platform/eclipse.platform#1673
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 33m 56s ⏱️ + 2m 30s
 7 732 tests ±0   7 504 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 357 runs  ±0  23 608 ✅ +1  749 💤 ±0  0 ❌  - 1 

Results for commit 8cb9d75. ± Comparison against base commit db41fb4.

@vogella vogella merged commit 650413a into eclipse-platform:master Jan 8, 2025
14 of 17 checks passed
@vogella
Copy link
Contributor

vogella commented Jan 8, 2025

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

@vogella
Copy link
Contributor

vogella commented Jan 8, 2025

Does discovery also need a lower bounds? eclipse-equinox/p2#604

@iloveeclipse
Copy link
Member

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery

@vogella
Copy link
Contributor

vogella commented Jan 8, 2025

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery

eclipse-equinox/p2#604

@vogella
Copy link
Contributor

vogella commented Jan 8, 2025

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery

project org.eclipse.equinox.p2.ui.discovery still uses the old org.eclipse.ui.internal.misc.TextMatcher AFAICS.

@iloveeclipse
Copy link
Member

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery

project org.eclipse.equinox.p2.ui.discovery still uses the old org.eclipse.ui.internal.misc.TextMatcher AFAICS.

Correct, I have assumed all of SDK is already migrated which seem not the case. Can you update eclipse-equinox/p2#604 please?

@vogella
Copy link
Contributor

vogella commented Jan 8, 2025

Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console

It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery

project org.eclipse.equinox.p2.ui.discovery still uses the old org.eclipse.ui.internal.misc.TextMatcher AFAICS.

Correct, I have assumed all of SDK is already migrated which seem not the case. Can you update eclipse-equinox/p2#604 please?

I do not have the time to apply the new API in discovery, if that is what you are asking.

If the new API is not used, I don't know if the minimum version increase will fix the build, please give you opinion in eclipse-equinox/p2#604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants