-
Notifications
You must be signed in to change notification settings - Fork 228
Update lower bound to org.eclipse.core.runtime due to new API #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lower bound to org.eclipse.core.runtime due to new API #2673
Conversation
The new StringMatcher API used with db41fb4 is only available starting with version 3.33.0 of org.eclipse.core.runtime. See eclipse-platform/eclipse.platform#1673
|
Aggregator build fails even with this change: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/80/console |
|
Does discovery also need a lower bounds? eclipse-equinox/p2#604 |
It fails because the update requested in #2672 wasn't done on org.eclipse.equinox.p2.ui.discovery |
|
project org.eclipse.equinox.p2.ui.discovery still uses the old org.eclipse.ui.internal.misc.TextMatcher AFAICS. |
Correct, I have assumed all of SDK is already migrated which seem not the case. Can you update eclipse-equinox/p2#604 please? |
I do not have the time to apply the new API in discovery, if that is what you are asking. If the new API is not used, I don't know if the minimum version increase will fix the build, please give you opinion in eclipse-equinox/p2#604 |
The new StringMatcher API used with
db41fb4 is only available starting with version 3.33.0 of org.eclipse.core.runtime.
See eclipse-platform/eclipse.platform#1673