Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Jan 11, 2025

There are some ongoing demands for providing custom icons to the Eclipse IDE or RCP applications.

This now adds an example of how such an "icon-pack" can be created and used inside Eclipse IDE.

@laeubi laeubi force-pushed the iconpack_example branch 2 times, most recently from df58d67 to d080936 Compare January 11, 2025 07:42
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2025

Test Results

0 files   -  1 818  0 suites   - 1 818   0s ⏱️ - 1h 39m 7s
0 tests  -  7 732  0 ✅  -  7 504  0 💤  - 228  0 ❌ ±0 
0 runs   - 24 357  0 ✅  - 23 608  0 💤  - 749  0 ❌ ±0 

Results for commit c50614b. ± Comparison against base commit 33f4606.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Jan 11, 2025

That is very cool. Thanks.

What would happen if we have multiple icon transformers defined? Last one to run wins?

@laeubi
Copy link
Contributor Author

laeubi commented Jan 11, 2025

What would happen if we have multiple icon transformers defined? Last one to run wins?

If they try to transform the same resource one will win (but I haven't checked wich one) maybe the one with highest bundle id.

There are some ongoing demands for providing custom icons to the Eclipse
IDE or RCP applications.

This now adds an example of how such an "icon-pack" can be created and
used inside Eclipse IDE.
@laeubi
Copy link
Contributor Author

laeubi commented Jan 11, 2025

The build passes but we have heavy outage, merging to get some progress into this and it is only an example:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5511

@laeubi laeubi merged commit d876bc7 into eclipse-platform:master Jan 11, 2025
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants