Mark long deprecated methods in AbstractUIPlugin for removal #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
reviewed
Jan 14, 2025
| int stickyScrollingMaxCount= store.getInt(EDITOR_STICKY_SCROLLING_MAXIMUM_COUNT); | ||
|
|
||
| Color lineNumberColor= new Color(PreferenceConverter.getColor(store, EDITOR_LINE_NUMBER_RULER_COLOR)); | ||
| sourceViewer.getTextWidget().addDisposeListener(e -> lineNumberColor.dispose()); |
Contributor
There was a problem hiding this comment.
It's a little confusing to see this change mixed into a PR about AbstractUIPlugin. Maybe this is accidental and meant to be in a different PR about not disposing colors?
Contributor
Author
There was a problem hiding this comment.
Sorry, forgot to rebase onto latest master. The already merged change is not removed from this PR.
Contributor
vogella
force-pushed
the
abstract-ui-plug-in-deprecated-methods-marked-for-deletion
branch
from
7961dc9 to
fcdd1a9
Compare
These methods are deprecated since a long time and should be marked for removal. This will enable us to delete them after the API deprecation period.
vogella
force-pushed
the
abstract-ui-plug-in-deprecated-methods-marked-for-deletion
branch
from
fcdd1a9 to
81ef63f
Compare
vogella
deleted the
abstract-ui-plug-in-deprecated-methods-marked-for-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are deprecated since a long time and should be marked for removal. This will enable us to delete them after the API deprecation period.