Skip to content

Stop using deprecated APIs in readme example #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Jan 18, 2025
Merged

Stop using deprecated APIs in readme example #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
034ef37
Stop using deprecated APIs in readme example
akurtakov Jan 18, 2025
91f7f29
Version bump(s) for 4.35 stream
eclipse-platform-bot Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ipse UI Examples Readme Tool/org/eclipse/ui/examples/readmetool/ReadmePreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2006 IBM Corporation and others.
* Copyright (c) 2000, 2025 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -14,6 +14,7 @@

package org.eclipse.ui.examples.readmetool;

import org.eclipse.core.runtime.preferences.InstanceScope;
import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.preference.PreferencePage;
import org.eclipse.swt.SWT;
Expand All @@ -31,6 +32,7 @@
import org.eclipse.ui.IWorkbench;
import org.eclipse.ui.IWorkbenchPreferencePage;
import org.eclipse.ui.PlatformUI;
import org.osgi.service.prefs.BackingStoreException;

/**
* This class implements a sample preference page that is added to the
Expand Down Expand Up @@ -287,7 +289,10 @@ protected void performDefaults() {
@Override
public boolean performOk() {
storeValues();
ReadmePlugin.getDefault().savePluginPreferences();
try {
InstanceScope.INSTANCE.getNode(ReadmePlugin.PLUGIN_ID).flush();
} catch (BackingStoreException e) {
}
return true;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/org.eclipse.ui.examples.readmetool/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.examples.readmetool; singleton:=true
Bundle-Version: 3.7.400.qualifier
Bundle-Version: 3.7.500.qualifier
Bundle-Activator: org.eclipse.ui.examples.readmetool.ReadmePlugin
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Expand Down
Loading