Add static method to the interface of ISharedImages to get the instance #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently one needs to first obtain the PaltformUI Workbench and then call getSharedImages on this instance. As this actually maps down to WorkBenchPlugin that do not require a running workbench this limits the usage of such code only wanting to share images. This adds a new ISharedImages.get() that directly calls the code the IWorkbench implementation would call and replace static calls to the workbench with this one.
Contributor
akurtakov
approved these changes
Jan 20, 2025
Member
akurtakov
left a comment
akurtakov
left a comment
There was a problem hiding this comment.
Looks good to me to have more direct access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one needs to first obtain the PaltformUI Workbench and then call getSharedImages on this instance. As this actually maps down to WorkBenchPlugin that do not require a running workbench this limits the usage of such code only wanting to share images.
This adds a new ISharedImages.get() that directly calls the code the IWorkbench implementation would call and replace static calls to the workbench with this one.
See for example: