Undeprecate updateToolbar() in FilteredTree and call again on refresh #2767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 3726516 due to which the updateToolbar() method is no longer called by the default refresh job. Subclasses may override updateToolbar() without also overriding doCreateRefreshJob() which in return means that their toolbar is not updated anymore. Because this method is called again, the deprecation tag introduced with 176f503 is also removed
Contributor
Author
|
See #2567 (comment) and #2567 (comment) |
Contributor
Test Results 1 821 files ±0 1 821 suites ±0 1h 34m 38s ⏱️ -58s For more details on these failures, see this check. Results for commit bc80d24. ± Comparison against base commit 55481d3. |
merks
approved these changes
Jan 31, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the super speedy response! 🚀
Contributor
Author
|
The failure in ProgressViewTests seems sprodaric and unrelated to this change. Given that the test succeeds locally, I'll merge this now. |
Contributor
|
Thanks!🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts 3726516 due to which the updateToolbar() method is no longer called by the default refresh job.
Subclasses may override updateToolbar() without also overriding doCreateRefreshJob() which in return means that their toolbar is not updated anymore.
Because this method is called again, the deprecation tag introduced with 176f503 is also removed