Respect user light/dark preference when restoring nonexistent theme #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When restoring a theme from preferences, which does not exist anymore.
we previously fell back to inherting from the operating system.
However, when when the user actively set the Eclipse theme to not match
the light/dark mode of the OS, we would then fall back again to
inheritance and override the user's choice.
To improve this, we look at the preference the user had actively chosen
before and see whether that was a dark theme or not and decide on that
which theme to fall back to.
Note: To check whether the theme is light or dark, we use the same
heuristic also used in other places, themeId.contains("dark"):
- org.eclipse.e4.ui.swt.internal.gtk.DarkThemeProcessor
- org.eclipse.e4.ui.swt.internal.win32.DarkThemeProcessor
- org.eclipse.e4.ui.swt.internal.cocoa.CocoaDarkThemeProcessor
Future improvements to consider, out of scope for this change:
- Move the heuristic themeId.contains("dark") to central place
and to re-use
- Even better, add an explicit "isDark" flag / preference somewhere
- On top of that, use a mode=dark/light/followSystem instead, see
also eclipse-platform#2440.
BeckerWdf
approved these changes
Feb 13, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring a theme from preferences, which does not exist anymore. we previously fell back to inherting from the operating system.
However, when when the user actively set the Eclipse theme to not match the light/dark mode of the OS, we would then fall back again to inheritance and override the user's choice.
To improve this, we look at the preference the user had actively chosen before and see whether that was a dark theme or not and decide on that which theme to fall back to.
Note: To check whether the theme is light or dark, we use the same heuristic also used in other places, themeId.contains("dark"):
Future improvements to consider, out of scope for this change:
Resolves: #2776
Closes: #2273