Skip to content

Conversation

@p-O-q
Copy link
Contributor

@p-O-q p-O-q commented Mar 4, 2025

Migration of test bundle org.eclipse.e4.ui.workbench.addons.swt.test from JUnit4 to JUnit5.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Test Results

 1 821 files  +  3   1 821 suites  +3   1h 33m 38s ⏱️ + 3m 59s
 7 900 tests +179   7 672 ✅ +180  228 💤 ±0  0 ❌  - 1 
23 787 runs   - 537  23 039 ✅  - 535  748 💤  - 1  0 ❌  - 1 

Results for commit e2558ef. ± Comparison against base commit c6fbe7d.

This pull request removes 182 and adds 361 tests. Note that renamed tests count towards both.
org.eclipse.e4.ui.workbench.addons.minmax.MaximizableChildrenTag ‑ testAreaMax
org.eclipse.e4.ui.workbench.addons.minmax.MaximizableChildrenTag ‑ testMainPartStackMax
org.eclipse.e4.ui.workbench.addons.minmax.MaximizableChildrenTag ‑ testPartStack1Max
org.eclipse.e4.ui.workbench.addons.minmax.MaximizableChildrenTag ‑ testPartStack2Max
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: false - maximizeMainFirst: false - addSubwindowToPerspective:false]
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: false - maximizeMainFirst: false - addSubwindowToPerspective:true]
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: false - maximizeMainFirst: true - addSubwindowToPerspective:false]
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: false - maximizeMainFirst: true - addSubwindowToPerspective:true]
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: true - maximizeMainFirst: false - addSubwindowToPerspective:false]
org.eclipse.e4.ui.workbench.addons.minmax.MaximizeBugTest ‑ testMainPartStackMaxSubPartStackMaxUnzoomMain[org.eclipse.ui.editorss: true - subwindowPerspective: true - maximizeMainFirst: false - addSubwindowToPerspective:true]
…
AllTests CleanupAddonTest ‑ testRemovingPrimaryDataStackTransfersToRemainingStack
AllTests MaximizableChildrenTag ‑ testAreaMax
AllTests MaximizableChildrenTag ‑ testMainPartStackMax
AllTests MaximizableChildrenTag ‑ testPartStack1Max
AllTests MaximizableChildrenTag ‑ testPartStack2Max
AllTests MaximizeBugTest ‑ testMainPartStackMax(boolean[])[1] [true, true, true, true]
AllTests MaximizeBugTest ‑ testMainPartStackMax(boolean[])[2] [true, true, false, true]
AllTests MaximizeBugTest ‑ testMainPartStackMax(boolean[])[3] [true, false, true, true]
AllTests MaximizeBugTest ‑ testMainPartStackMax(boolean[])[4] [true, false, false, true]
AllTests MaximizeBugTest ‑ testMainPartStackMax(boolean[])[5] [true, true, true, false]
…

♻️ This comment has been updated with latest results.

@p-O-q p-O-q force-pushed the migrate-to-junit5 branch 2 times, most recently from b9ff68e to f6b2909 Compare March 5, 2025 08:41
@p-O-q
Copy link
Contributor Author

p-O-q commented Mar 5, 2025

@akurtakov As far as I can see, the warnings are not being introduced by my PR. I don't think there is anything I can do at the moment.
Please let me know if I am wrong or if I can help.

@akurtakov
Copy link
Member

Warnings are due to new stream opening and should be fixed with #2826 . I'm rebasing this one.

@akurtakov akurtakov force-pushed the migrate-to-junit5 branch from f6b2909 to ec8ad80 Compare March 5, 2025 09:34
Migration of test bundle org.eclipse.e4.ui.workbench.addons.swt.test from JUnit4 to JUnit5.
@akurtakov akurtakov force-pushed the migrate-to-junit5 branch from ec8ad80 to e2558ef Compare March 5, 2025 15:14
@akurtakov akurtakov merged commit 60b8674 into eclipse-platform:master Mar 5, 2025
17 checks passed
@akurtakov
Copy link
Member

Thanks for this one! Much appreciated.

@p-O-q
Copy link
Contributor Author

p-O-q commented Mar 5, 2025

@akurtakov Thank you for the effort you put into this PR :)

@p-O-q p-O-q deleted the migrate-to-junit5 branch March 5, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants