Skip to content

Add SVGs to org.eclipse.ltk.ui.refactoring #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Michael5601
Copy link
Contributor

This PR adds SVGs for all icons in the bundles org.eclipse.ltk.ui.refactoring except for the following as these are not available as SVG yet:

wizban/apply_rescript_wiz.svg
wizban/create_rescript_wiz.svg
wizban/show_history_wiz.svg

See also this PR for more information.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 293b074a10e8b6dd3efca26afd01766af623db3d Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 15 Apr 2025 12:55:44 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
index eac535e118..eef5291b7f 100644
--- a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.ui.refactoring
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.ui.refactoring; singleton:=true
-Bundle-Version: 3.13.500.qualifier
+Bundle-Version: 3.13.600.qualifier
 Bundle-Activator: org.eclipse.ltk.internal.ui.refactoring.RefactoringUIPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 38m 1s ⏱️ - 1m 27s
 7 918 tests ±0   7 690 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 841 runs  ±0  23 093 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 7ba93d9. ± Comparison against base commit 7302fcc.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.ltk.ui.refactoring.SVGs branch 2 times, most recently from 238ea45 to b96ae57 Compare April 20, 2025 08:01
Michael5601 and others added 2 commits April 22, 2025 12:52
This commit adds SVGs for all icons in the bundle `org.eclipse.ltk.ui.refactoring` except for the following as these are not available as SVG yet:

wizban/apply_rescript_wiz.svg
wizban/create_rescript_wiz.svg
wizban/show_history_wiz.svg
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ltk.ui.refactoring.SVGs branch from b96ae57 to 512e36b Compare April 22, 2025 10:53
Use on-the-fly-generated disabled version of SVG-rasterized icons
instead.
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ltk.ui.refactoring.SVGs branch from 512e36b to 7ba93d9 Compare April 22, 2025 10:53
@HeikoKlare
Copy link
Contributor

Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892

Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR.

@HeikoKlare HeikoKlare merged commit 7d43b94 into eclipse-platform:master Apr 22, 2025
11 of 13 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.ltk.ui.refactoring.SVGs branch April 22, 2025 11:44
@HeikoKlare
Copy link
Contributor

No new issues on subsequent master build for 7d43b94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants