Skip to content

Add SVGs to org.eclipse.ui.browser #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael5601
Copy link
Contributor

This PR adds SVGs for all icons in the bundles org.eclipse.ui.browser.

See also this PR for more information.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

 1 824 files  + 1 824   1 824 suites  +1 824   1h 30m 43s ⏱️ + 1h 30m 43s
 7 918 tests + 7 918   7 689 ✅ + 7 689  228 💤 +228  1 ❌ +1 
23 841 runs  +23 841  23 092 ✅ +23 092  748 💤 +748  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 8c88a6f. ± Comparison against base commit d4ffd3f.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.browser.SVGs branch 3 times, most recently from 5bb79fe to 1e821b0 Compare April 23, 2025 06:12
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.browser.SVGs branch from 1e821b0 to a615a56 Compare April 24, 2025 15:20
Michael5601 and others added 2 commits April 26, 2025 14:42
This commit adds SVGs for all icons in the bundle org.eclipse.ui.browser except for the following as these are not available as SVG yet:
Use on-the-fly-generated disabled version of SVG-rasterized icons
instead.
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.browser.SVGs branch from a615a56 to 8c88a6f Compare April 26, 2025 12:42
@HeikoKlare
Copy link
Contributor

Test failure is unrelated: #294

@HeikoKlare HeikoKlare merged commit 6683c3f into eclipse-platform:master Apr 26, 2025
9 of 11 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.ui.browser.SVGs branch April 26, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants