Skip to content

Add SVGs to org.eclipse.ui.genericeditor bundles #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael5601
Copy link
Contributor

@Michael5601 Michael5601 commented Apr 15, 2025

This PR adds SVGs for all icons in the bundles org.eclipse.ui.genericeditor and org.eclipse.ui.genericeditor.tests .

See also this PR for more information.

❗ This depends on and thus has to be merged after #2913

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d93b3de30d8651d409a81a3380cb63db9779dc85 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 15 Apr 2025 13:19:46 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
index d62bf36af5..c7a166b53c 100644
--- a/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.genericeditor.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.genericeditor.tests;singleton:=true
-Bundle-Version: 1.3.700.qualifier
+Bundle-Version: 1.3.800.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.genericeditor.tests,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

 1 824 files   1 824 suites   1h 32m 57s ⏱️
 7 918 tests  7 690 ✅ 228 💤 0 ❌
23 841 runs  23 093 ✅ 748 💤 0 ❌

Results for commit 9e8e31f.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.genericeditor branch from 6cca023 to 99b5938 Compare April 24, 2025 11:59
Michael5601 and others added 3 commits April 26, 2025 16:18
This commit adds SVGs for all icons in the bundles `org.eclipse.ui.genericeditor` and `org.eclipse.ui.genericeditor.tests` .
Use on-the-fly-generated disabled version of SVG-rasterized icons
instead.
@HeikoKlare HeikoKlare force-pushed the org.eclipse.ui.genericeditor branch from 99b5938 to 9e8e31f Compare April 26, 2025 14:18
@HeikoKlare HeikoKlare merged commit 5e86927 into eclipse-platform:master Apr 26, 2025
11 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.ui.genericeditor branch April 27, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants