Add SVGs to org.eclipse.e4.ui bundles #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 1 824 files 1 824 suites 1h 30m 55s ⏱️ Results for commit 6a9df62. ♻️ This comment has been updated with latest results. |
This commit adds SVGs for all icons in the bundles `org.eclipse.e4.ui.progress`, `org.eclipse.e4.ui.workbench.swt`, `org.eclipse.e4.ui.workbench.renderers.swt`, `org.eclipse.e4.ui.workbench.addons.swt` and `org.eclipse.e4.ui.tests`, `org.eclipse.e4.ui.dialogs`.
Use on-the-fly-generated disabled version of SVG-rasterized icons instead.
HeikoKlare
force-pushed
the
org.eclipse.e4.SVGs
branch
from
ab4ec5c to
6a9df62
Compare
HeikoKlare
approved these changes
Apr 22, 2025
|
Merging this despite Jenkins failure caused by https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 Since master builds seem to still work on Jenkins, the subsequent master build should hopefully work, thus I will check results of that build to retrospectively validate this PR. |
|
No new issues on subsequent master build for bcd6dd1 |
sratz
added a commit
to sratz/eclipse.platform.ui
that referenced
this pull request
May 19, 2025
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on eclipse-platform#2925.
Merged
sratz
added a commit
to sratz/eclipse.platform.ui
that referenced
this pull request
May 19, 2025
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on eclipse-platform#2925. Uses the updated icons taken from eclipse-platform/eclipse.platform.images#147
sratz
added a commit
that referenced
this pull request
May 19, 2025
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on #2925. Uses the updated icons taken from eclipse-platform/eclipse.platform.images#147
IamLRBA
pushed a commit
to IamLRBA/eclipse.platform.ui
that referenced
this pull request
Jul 14, 2025
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on eclipse-platform#2925. Uses the updated icons taken from eclipse-platform/eclipse.platform.images#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SVGs for all icons in the bundles
org.eclipse.e4.ui.progress,org.eclipse.e4.ui.workbench.swt,org.eclipse.e4.ui.workbench.renderers.swt,org.eclipse.e4.ui.workbench.addons.swtandorg.eclipse.e4.ui.tests,org.eclipse.e4.ui.dialogs.See also this PR for more information.