Skip to content

Use constructor Image(Device, ImageDataProvider) for Radial gradients #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use constructor Image(Device, ImageDataProvider) for Radial gradients #3040

wants to merge 1 commit into from

Conversation

arunjose696
Copy link

This PR does not cause a visual impact but is meant for completeness to replace Image(Device, ImageData) with Image(Device, ImageDataProvider), making sure the earlier behaviour is preserved.

Steps to reproduce

The radial gradients are in the CSS selector.

  1. Open CSS Spy
  2. For the background color field, enter a list that is a radial gradient. I entered the below list:
gradient radial white black gainsboro lightgray silver gray dimgray darkslategray black midnightblue navy darkblue mediumblue blue dodgerblue deepskyblue lightseagreen mediumseagreen seagreen forestgreen green darkgreen

Screenshot

Provider_225

@arunjose696
Use constructor Image(Device, ImageDataProvider) for Radial gradients
81dc48a 
This PR does not cause a visual impact but is meant for completeness to
Replace Image(Device, ImageData) with Imagde(Device, ImageDataProvider)
making sure the earlier behaviour is preserved
@arunjose696 arunjose696 linked an issue Jun 12, 2025 that may be closed by this pull request
Evaluate calling places of Image constructors with ImageData vi-eclipse/Eclipse-Platform#199
Open
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From cf3ee664ffebe636cf2f0bedd5f403a7998e8c64 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 13 Jun 2025 09:00:44 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
index 9e193a6310..d704b7f44e 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true
-Bundle-Version: 0.15.600.qualifier
+Bundle-Version: 0.15.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

0 files   -  2 778  0 suites   - 2 778   0s ⏱️ - 1h 47m 44s
0 tests  -  7 928  0 ✅  -  7 700  0 💤  - 228  0 ❌ ±0 
0 runs   - 23 339  0 ✅  - 22 593  0 💤  - 746  0 ❌ ±0 

Results for commit 81dc48a. ± Comparison against base commit 5dc925c.

@arunjose696 arunjose696 mentioned this pull request Jul 3, 2025
Open
@arunjose696 arunjose696 linked an issue Jul 3, 2025 that may be closed by this pull request
Use constructor Image(Device, ImageDataProvider) for Radial gradients vi-eclipse/Eclipse-Platform#348
Open
amartya4256
amartya4256 reviewed Jul 30, 2025
View reviewed changes
...lipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/GradientBackgroundListener.java
// + (System.currentTimeMillis() - startTime) + " ms");
gradientImage = new Image(control.getDisplay(), imagedata);
ImageDataProvider imageDataProvider = zoom -> {
float scaleFactor = zoom / 100.0f;
Copy link
Contributor

@amartya4256 amartya4256 Jul 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also just say 100f

@amartya4256
Copy link
Contributor

The CI builds seem to be failing because of the version inconsistency. Can you have a look at the logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@amartya4256 amartya4256 amartya4256 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use constructor Image(Device, ImageDataProvider) for Radial gradients Evaluate calling places of Image constructors with ImageData
3 participants
@arunjose696 @eclipse-platform-bot @amartya4256